Add Rust to our set of tools
What does this MR do and why?
Add Rust to our set of tools. Part of #381569 (closed) and needs to ship with gitlab-development-kit!2816 (closed).
Warning
This does not automatically install the rust tool chain. I wonder if this could be a source of confusion for developers. How did we handle additions to tools in the past? Do we just push through it, as it is a one time thing, or do we need to provide some automation?
Screenshots or screen recordings
How to set up and validate locally
asdf install rust 1.65.0
rustc --version
rustc 1.65.0 (897e37553 2022-11-02)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @lamportsapprentice
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer maintenanceworkflow / maintenancepipelines for CI, Danger Michael Becker (
@wandering_person
) (UTC-8)Dylan Griffith (
@DylanGriffith
) (UTC-6)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded Incubation Engineering Department typefeature labels
added featureaddition label
changed milestone to %Next 1-3 releases
mentioned in merge request gitlab-development-kit!2816 (closed)
- Resolved by Ash McKenzie
@rzwambag I'd like to loop you in here. I think we probably need someone familiar with
asdf
to help us a bit, so cc/ing @ashmckenzie as well.
requested review from @rzwambag
requested review from @ashmckenzie
- Resolved by Brett Walker
removed review request for @rzwambag
@rzwambag
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @ashmckenzie
requested review from @ddieulivol