Skip to content

Validate email on the almost there page

Serhii Yarynovskyi requested to merge sy-221-text-injection-with-signup-onboarding into master

Related to https://gitlab.com/gitlab-org/secure/general/-/issues/221+

What does this MR do and why?

The endpoint at users/almost_there fails to validate the email taken from the query params.

Screenshots or screen recordings
Screenshot_2022-11-14_at_14.33.02 Screenshot_2022-11-14_at_14.28.17

How to set up and validate locally

  • Visit /users/almost_there?email=Hello%20this%20could%20be%20a%20text.
  • Make sure there is no Hello this could be a text text.
  • Visit /users/almost_there?email=こんにちは@test.
  • Make sure email with Japanese hieroglyphs is rendered correctly.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Serhii Yarynovskyi

Merge request reports