Update GitLab UI/SVG
This MR contains the following updates:
Package | Type | Update | Change |
---|---|---|---|
@gitlab/svgs | dependencies | minor | 3.7.0 -> 3.8.0 |
@gitlab/ui | dependencies | minor | 49.3.0 -> 49.11.0 |
MR created with the help of gitlab-org/frontend/renovate-gitlab-bot
Configuration
-
If you want to rebase/retry this MR, click this checkbox. Warning: custom changes will be lost.
This MR has been generated by Renovate Bot.
Merge request reports
Activity
Renovate Comment
This Merge Request has been created with the help of renovate-gitlab-bot project.
What are the next steps?
If you have been assigned as a reviewer to this Merge Request, please review this Merge Request with the same scrutiny as any community contribution:
-
Ensure that the dependencies updated meet our standards:
- Security: Dependencies do not contain malicious code
- Performance: Dependencies do not bloat the application code or prolong CI times unnecessarily
- Stability: Pipelines are passing
-
Review the changes introduced by the version upgrade. Consider using [https://my.diffend.io] to compare the two versions in case the updated dependency is either a Ruby Gem or a Node.js package, for example to compare
pg_query
2.1.0
and2.1.4
. -
If tests are passing and you've reviewed the updated dependencies, execute pipelines in the context of the main project
This MR is created from a fork, therefore not all jobs (e.g. Danger) might have been executed. Instead of hitting MWPS right away, you might want to wait until the pipeline you've just triggered finished.
Note: This might not be available in projects, in that case merging right away is an option
-
Merge away!
Troubleshooting
We have assembled some FAQs to help reviewers of these kind of merge requests.
Improve this message – The JSON comment below is for automation purposes.
{"labels":["frontend","maintenance::dependency","type::maintenance","automation:bot-authored"],"assignees":["gitlab-dependency-update-bot"],"reviewers":["dmishunov","ealcantara","pgascouvaillancourt","mikegreiling","ohoral","markrian","svedova"]}
-
assigned to @gitlab-dependency-update-bot
mentioned in issue #365044
added 75 commits
-
2cd2ea94...c2b9a836 - 74 commits from branch
gitlab-org:master
- 3962e38f - Update dependency @gitlab/ui to v49.7.0
-
2cd2ea94...c2b9a836 - 74 commits from branch
added 5 commits
-
3962e38f...0a62f4a6 - 4 commits from branch
gitlab-org:master
- e8e37ab3 - Update dependency @gitlab/ui to v49.8.0
-
3962e38f...0a62f4a6 - 4 commits from branch
added 55 commits
-
e8e37ab3...d0a45b46 - 54 commits from branch
gitlab-org:master
- 202404f4 - Update dependency @gitlab/ui to v49.8.0
-
e8e37ab3...d0a45b46 - 54 commits from branch
- Resolved by Olena Horal-Koretska
Hi @svedova, @ohoral
Just FYI, a recent contribution of mine to GitLab UI, unfortunately, broke theGlDaterangePicker
layout. It's not very used on GitLab as the product, but it could break the layout of a couple of pages (these are the ones I found that are using it):app/assets/javascripts/analytics/shared/components/daterange.vue
ee/app/assets/javascripts/audit_events/components/date_range_field.vue
ee/app/assets/javascripts/compliance_dashboard/components/violations/filter.vue
I already pushed up a fix with gitlab-ui!3141 (merged), which is waiting for review
I just wanted to let you know after I say the problems with !103040 (merged)
added 242 commits
-
202404f4...f6a9b26c - 241 commits from branch
gitlab-org:master
- a3b48a16 - Update dependency @gitlab/ui to v49.8.0
-
202404f4...f6a9b26c - 241 commits from branch
added 187 commits
-
a3b48a16...44212ea4 - 186 commits from branch
gitlab-org:master
- d3065bb9 - Update dependency @gitlab/ui to v49.9.0
-
a3b48a16...44212ea4 - 186 commits from branch
added 7 commits
-
d3065bb9...01521c7a - 6 commits from branch
gitlab-org:master
- 13765476 - Update GitLab UI/SVG
-
d3065bb9...01521c7a - 6 commits from branch
mentioned in issue gitlab-ui#2007 (closed)
added 197 commits
-
13765476...3a9710e5 - 196 commits from branch
gitlab-org:master
- 66840514 - Update GitLab UI/SVG
-
13765476...3a9710e5 - 196 commits from branch
added 81 commits
-
66840514...2d1e644a - 80 commits from branch
gitlab-org:master
- afff34ec - Update GitLab UI/SVG
-
66840514...2d1e644a - 80 commits from branch
assigned to @pgascouvaillancourt
2 Warnings This merge request is quite big (1071 lines changed), please consider splitting it into multiple merge requests. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5)Florie Guibert (
@fguibert
) (UTC+10)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3ba4dc7b and f4be9dd7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 1.96 MB 1.96 MB - -0.0 % average 3.61 MB 3.61 MB - 0.0 %
Note: We do not have exact data for 3ba4dc7b. So we have used data from: c344e860.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for f4be9dd7expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 818 | 0 | 27 | 10 | 845 | ❗ | | Plan | 312 | 0 | 0 | 0 | 312 | ✅ | | Package | 144 | 0 | 37 | 31 | 181 | ❗ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Govern | 199 | 0 | 10 | 0 | 209 | ✅ | | Verify | 229 | 0 | 42 | 0 | 271 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Manage | 354 | 0 | 75 | 12 | 429 | ❗ | | Secure | 30 | 0 | 10 | 10 | 40 | ❗ | | Fulfillment | 10 | 0 | 75 | 0 | 85 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Systems | 3 | 0 | 0 | 0 | 3 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Data Stores | 12 | 0 | 1 | 0 | 13 | ✅ | | Version sanity check | 0 | 0 | 7 | 7 | 7 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2155 | 0 | 305 | 70 | 2460 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
mentioned in merge request gitlab-ui!3152 (merged)
added 70 commits
-
3cc107b2...85138b2d - 67 commits from branch
gitlab-org:master
- b595e66e - Update GitLab UI/SVG
- 2bbe64c8 - Update GitLab's neutral colors
- f4be9dd7 - Update startup CSS
Toggle commit list-
3cc107b2...85138b2d - 67 commits from branch
@ohoral
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 92245df3 succeeds
Merge request already has "MWPS" set.
Adding automation:bot-no-updates in order to prevent renovate from updating the MR.
If you want the MR to be updated again, please remove the label and check the "rebase checkbox" in the description.
added automation:bot-no-updates label
mentioned in commit dce73b8e
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
@nickbrandt I see you had a commit pushed by smomeone else to update the colors in darkmode. Here is some feedback:
First (personal opinion): I don't like the new colors at all, at least for me, it makes it more difficult to look at GitLab for a longer period of time.
Secondly: I think, the colors which currently build up the dark theme don't fit that well together.
What? Old New Table headings Reply boxes Combination with navbar and MR titles All Threads resolved The darkmode is getting blue-ish and I really liked the grey we had before
@Taucher2003 thank you taking the time to provide feedback!
First (personal opinion): I don't like the new colors at all, at least for me, it makes it more difficult to look at GitLab for a longer period of time.
Color can often times be a very opinionated matter, as you point out. The intent for this change was to align us closer to our branding while bringing a little life to the otherwise very dull/flat neutral palette that existed. You can read more about this effort in gitlab-org/gitlab-services/design.gitlab.com#1452 (closed).
Regarding some of the screenshots you have included around portions of the page/components not seeming to fit very well together – this is attributed to some instances that were not previously utilizing our gray variables (hence they were not updated accordingly). We will be working to update those instances which should resolve the inconsistencies you are seeing.
Our hope is that this change wouldn't invoke a negative experience for our users, but instead the opposite. We will be monitoring feedback around this update and will iterate as needed in an effort to make the experience pleasant for everyone. Dark mode is currently in
alpha
, and it's something we are hoping to put more focus towards in the near future to make that overall experience better.@Taucher2003 you should notice a change in dark mode soon that fixes a majority of the inconsistencies I mentioned regarding variables (currently already on Next/canary). Hopefully this addresses some of your concerns, but let me know if you have any additional feedback
added workflowstaging label and removed workflowcanary label
mentioned in merge request !104325 (merged)
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label