Upgrade to PostgreSQL 12.13 and 13.9 in .tool-versions
What does this MR do and why?
This will fix issues with building on XCode 14.1.
Relates to gitlab-development-kit#1586 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stanhu
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %15.6
added maintenancedependency typemaintenance labels
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer maintenanceworkflow / maintenancepipelines for CI, Danger Jay Montal (
@jmontal
) (UTC-7, 1 hour ahead of@stanhu
)Kerri Miller (
@kerrizor
) (UTC-8, same timezone as@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @ashmckenzie
mentioned in issue gitlab-development-kit#1586 (closed)
I'll need to perform some testing here as I observed issues with this and was investigating as part of gitlab-development-kit!2680 (merged). It's probably OK here given we're just bumping the minor versions and remaining with the major, but need to be careful
- Resolved by Ash McKenzie
That's a pretty old merge request. I'm confused how this relates to gitlab-development-kit!2680 (merged) at all.
mentioned in commit gitlab-development-kit@b34d2c55
mentioned in merge request gitlab-development-kit!2809 (merged)
@ashmckenzie
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
@ashmckenzie, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 2f9da552
mentioned in issue gitlab-development-kit#1595
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in issue gitlab-development-kit#1635 (closed)
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !117811 (merged)