Skip to content

Enforce HTTP/HTTPS schemes in Octokit Middleware

Rodrigo Tomonari requested to merge rodrigo/enforce-schemes-in-octokit-midware into master

What does this MR do and why?

Octokit Middleware is used to validate the URL of all requests to GitHub / GitHub Enterprise API. It's similar to Gitlab::HTTPConnectionAdapter.

This change updates the middleware to enforce that the schemes HTTP/HTTPS are used.

Related to: #372317 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Just testing if GitHub Import is still working is fine.

  1. Go to projects
  2. New project
  3. Import project
  4. Select GitHub
  5. Import a project
  6. Check if the project was imported

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rodrigo Tomonari

Merge request reports