Skip to content

Move Seed logic for Deployment and Environment to Service class

Shinya Maeda requested to merge refactor-seed-deployment-environment into master

What does this MR do and why?

This MR moves logic of creating Environments/Deployments to service classes from seed classes. This allows us to use the same service in the other places, such as Job retry and play.

  • Logic in Pipeline::Seed::Deployment is moved to Deployments::CreateForBuildService
  • Logic in Pipeline::Seed::Environment and Pipeline::Chain::EnsureEnvironments is moved to Environments::CreateForBuildService

Notes:

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports

Loading