Skip to content

Support fully qualified refs for graphs view

Jerry Seto requested to merge 219583-networks-page into master

What does this MR do and why?

Support fully qualified refs for graphs view

  • updates Projects:NetworkController to handle ref_type
  • refactors tests

Contributes to: #219583 (closed)

How to set up and validate locally

  1. Enable the use_ref_type_parameter feature flag
  2. Set up a project
  3. checkout a new branch with some commits and push
  4. checkout the previous branch, add a tag and push tags For example
git checkout -b "ambiguous-ref-name"
touch somefile.md
git add somefile.md
git commit -m "A commit"
git push origin ambiguous-ref-name
git checkout main
git tag ambiguous-ref-name
git push --tags
  1. Go to the graphs/networks page

Screen_Shot_2022-11-30_at_4.48.44_PM

  1. Try switching between tag and branch refs and see that a different node is indicated in the graph

Screen_Shot_2022-11-30_at_5.00.17_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #219583 (closed)

Edited by Jerry Seto

Merge request reports