Skip to content

Add CI/CD variables shared apollo structure

What does this MR do and why?

We did a big refactor recently to use apollo in CI/CD variable settings. There was a lot of restructuring but one thing that we did not have room to do in the initial MR was to generalize the similar fetching behaviours. This MR intends to fix this by removing from the topmost components of the applications (Project, Group and admin) the shared logic and making it a child component that inherits some props, which in turn the new child component uses to build it's graphql queries.

To consider this refactor is a success, the new shared component should be completely agnostic to where it is used so that removing or adding a new parent does not affect this shared component at all.

Screenshots or screen recordings

Hopefully no changes 🤞🏻

How to set up and validate locally

  1. Go to Settings => CI/CD
  2. Scroll to variables
  3. Add, edit and remove variables: everything should work as usual

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #378332 (closed)

Edited by Frédéric Caplette

Merge request reports

Loading