Add `disable_download_button` application-setting for JH-only feature
What does this MR do and why?
Add an application setting disable_download_button
for JH-only feature
Related MR: !1112(jihulab) Related GitLab discussion thread: #17032 (comment 1111639731)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
/cc @daveliu
Merge request reports
Activity
added JiHu contribution label
Hey @LXY1226!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @LXY1226
- Resolved by LXY
@songhuangcn
could you help me review this as peer review?
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Notification to the Data Team about changes to files with possible impact on Data Warehouse, add label
Data Warehouse::Impact Check
.The following files require a review:
db/structure.sql
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan (
@sashi_kumar
) (UTC+1)Sean McGivern (
@smcgivern
) (UTC+0)database Huzaifa Iftikhar (
@huzaifaiftikhar1
) (UTC+5.5)Adam Hegyi (
@ahegyi
) (UTC+1)frontend Stanislav Lashmanov (
@slashmanov
) (UTC+4)Kushal Pandya (
@kushalpandya
) (UTC+5.5)~"migration" No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 2569c121 - Add `disable_download_button` application-setting for JH-only feature
added 1 commit
- 7941c965 - Add `disable_download_button` application-setting in database for JH-only feature Changelog
added 1 commit
- 53df89c1 - Add `disable_download_button` application-setting for JH-only feature Changelog
added 1 commit
- cf68ea67 - Add `disable_download_button` settings for JH-only feature Changelog
mentioned in issue gitlab-org/quality/triage-reports#9899 (closed)
added 1 commit
- db6e60b4 - Add `disable_download_button` settings for JH-only feature Changelog
added 1 commit
- cfcab564 - Add `disable_download_button` settings for JH-only feature Changelog
mentioned in issue gitlab-jh/status-reports#172
added 1 commit
- 18712834 - Add `disable_download_button` settings for JH-only feature Changelog
mentioned in issue gitlab-org/quality/triage-reports#9903 (closed)
added groupsource code label
added devopscreate sectiondev labels