Skip to content

Skip create group level push rule when creating group

Yongbo li requested to merge gitlab-jh/jh-team/gitlab:refact/skip_create_group_rule into master

What does this MR do and why?

Actually there is no need to create group level push rule until user meant to.
Create project under group can use PushRule.global as default

Solve: #363821.
pervious mr: !102360 (merged)

create push rule for project flow

graph TD
    G[Create project] --> A[has group]
    A -->|false| B(create rule from global)
    A -->|true| C(Search predefined rule in group)
    C -->|rule exist| D(create rule from group)
    C -->|can not find any rules| B
    B --> *
    D --> *

If group do not have own push rule, group.predefined_push_rule would return PushRule.global another mr simlyify creat push rule for project

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Yongbo li

Merge request reports