Skip to content

Do not show an error when polling notes fails

Nicolas Dular requested to merge nd/do-not-error-on-notes-polling into master

What does this MR do and why?

Issue: #381431

When a user is on the Issue or Merge Request page, we poll for new notes for the issuable. When the request fails for two times, we show an error.

While we technically remove the error again once the user has a connection again, I'd argue we should not show it in the first place as the user never initiated an action.

With this MR we remove the error message.

Screenshots or screen recordings

Before After
before_1080 after_1080

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nicolas Dular

Merge request reports