Skip to content

E2E - Add new web directory webide spec for vscode IDE

Jason Zhang requested to merge jz-add-new-web-directory-webide-spec into master

What does this MR do and why?

Add new spec for VSCode IDE - based off the old qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb

Part 1 - Steps

  1. User Creates an Project with a Directory
  2. User opens VSCode IDE and creates a new Directory with the same name
  3. User encounters an error

Part 2 - Steps

  1. User Creates an Project
  2. User opens VSCode IDE and creates a new Directory with an empty name
  3. User tries to commit via VScode IDE
  4. User sees there's nothing to commit within VSCode IDE

Notes:

  • We do not have qa-selectors for components within the iframe
  • Selecting elements within the iframe themselves are extremely flaky - My solution, is to cheat a bit and use hot-keys. use Support::Waiter.wait_until
  • Sleeps used to stabilize tests within iframe - Some elements simply can't be waited until visible to stabilize

Screenshots or screen recordings

image

image Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Tip to play around with the feature: Open Rails console and run Feature.enable(:vscode_web_ide) to enable the Feature Flag.

or just run:

bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ qa/specs/features/browser_ui/3_create/web_ide_new/add_new_directory_in_web_ide_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jason Zhang

Merge request reports