Skip to content

Use the same sanitize method for advanced and basic search

Terri Chu requested to merge 338984-global-search-results-should-not-render-html into master

What does this MR do and why?

Fixes an issue where HTML is being displayed in search results for issues

Update specs

Related to #338984 (closed)

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

Note: gdk must have Elasticsearch setup, Advanced Search enabled, and data indexed to test this locally

  1. add a new issue with the following text
Click to expand 
<h2 data-sourcepos="11:1-11:26" dir="auto"><a id="user-content-additional-information" class="anchor" href="#additional-information" aria-hidden="true"></a>Additional information:</h2><textarea data-update-url="/freepascal.org/fpc/source/-/issues/6163.json" dir="auto" data-testid="textarea" class="hidden js-task-list-field"></textarea>
  1. search for the issue
  2. verify the search results have does not render the html

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports