Skip to content

Remove artifacts finder call from artifacts page to stop 500s

What does this MR do and why?

The artifacts page is behind the artifacts_management_page feature flag.

We can remove this expensive artifacts finder call now that we've changed this page to use vue/graphql instead. Hopefully this will fix the performance issues that we encountered the last time this feature flag was enabled, and stop the artifacts page from throwing 500 errors for gitlab-org/gitlab (https://gitlab.com/gitlab-org/gitlab/-/artifacts).

Screenshots or screen recordings

the page title and total artifacts size will be moved to vue/graphql in !103075 (merged)
Screen_Shot_2022-11-02_at_12.31.39
It's okay if this is blank in the meantime because this page is behind a feature flag

How to set up and validate locally

  1. echo "Feature.enable(:artifacts_management_page)" | bundle exec rails console
  2. git checkout mfluharty-remove-artifacts-finder-call
  3. find/make/import a project with a pipeline with a job that generates artifacts
you can use this CI yaml to generate some sample artifacts:
# .gitlab-ci.yml

potato:
  stage: build
  script:
    - echo 'potato' >> potato.txt
  artifacts:
    expose_as: 'potato'
    paths: ['potato.txt']

tomato:
  stage: build
  script:
    - echo 'tomato' >> tomato.txt
  artifacts:
    expose_as: 'tomato'
    paths: ['tomato.txt']

pineapple:
  stage: build
  script:
    - echo 'pineapple' >> pineapple.txt
  artifacts:
    expose_as: 'pineapple'
    paths: ['pineapple.txt']

apple:
  stage: build
  script:
    - echo 'apple' >> apple.txt
  artifacts:
    expose_as: 'apple'
    paths: ['apple.txt']

toblerone:
  stage: build
  script:
    - echo 'toblerone' >> toblerone.txt
  artifacts:
    expose_as: 'toblerone'
    paths: ['toblerone.txt']
  1. run a pipeline for that project - for this you'll need to set up a local runner for GDK or enable runners in gitpod
  2. navigate to the project, and in the sidebar select CI/CD => Artifacts
  3. artifacts should still appear on this page because we're now getting them through graphql

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miranda Fluharty

Merge request reports

Loading