Show DAST in Group Security Dashboard Back-End
What does this MR do?
BE changes that allow DAST vulnerabilities to be visible from Group Dashboard.
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ee/issues/8483
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.10
added Category:DAST devopssecure ~2975006 + 1 deleted label
@markrian here are BE changes for #8483 (closed) As you can see I removed at all a scope for report types, as from now we show all available report types.
mentioned in commit d8894473
mentioned in commit 60bdbe49
mentioned in merge request !10271 (merged)
mentioned in issue #8483 (closed)
added 198 commits
-
1c67dab3...86892ebc - 195 commits from branch
master
- bbcf81e4 - Remove scope for report types
- 1ef6523a - Enable DAST feature
- df225ba6 - Roll back tests
Toggle commit list-
1c67dab3...86892ebc - 195 commits from branch
1 Warning ⚠ This merge request is missing the ~Documentation label. 1 Message 📖 This merge request adds or changes files that require a review from the Technical Writing team. Documentation review
The following files require a review from a technical writer:
doc/user/group/security_dashboard/index.md
The review does not need to block merging this merge request. See the:
- DevOps stages for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer ~Documentation Achilleas Pipinellis ( @axil
)backend Lucas Charles ( @theoretick
)Kamil Trzciński ( @ayufan
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Tests added for this feature/bug as completed
assigned to @gonzoyumo
@gonzoyumo could you please review this MR? Thanks!
added 1 commit
- c9115d60 - Add DAST and CS to requirements for the dashboard
- Resolved by Achilleas Pipinellis
Thanks @brytannia, LGTM!
@ayufan can you please validate this?
Also @axil could you please review the documentation updates?
Thanks.
assigned to @ayufan
added documentation label
marked the checklist item Conforms to the code review guidelines as completed
marked the checklist item Conforms to the merge request performance guidelines as completed
marked the checklist item Conforms to the style guides as completed
assigned to @axil
assigned to @gonzoyumo
@ayufan it seems that every required approval are there, can you please merge this? Thanks.
assigned to @ayufan
mentioned in commit a8a42ab0
mentioned in merge request !10487 (merged)
mentioned in merge request !10503 (merged)
mentioned in issue gitlab-org/release/tasks#731 (closed)
mentioned in issue #10048 (closed)
added Enterprise Edition label