Skip to content
Snippets Groups Projects

Enable Ci::PartitioningAnalyzer

Merged Max Orefice requested to merge morefice/enable-ci-partitioninganalyzer into master
All threads resolved!

Ref: #377535 (closed)

What does this MR do and why?

This MR enables Ci::PartitioningAnalyzer analyzer to make sure all queries targeting ci_builds_metadata are now using the routing table for development and testing environment.

In order to accomplish this, I decided to split our existing analyzer in 2 as this was causing many spec failures to disable on feature flag for testing environment.

  • Ci::PartitioningRoutingAnalyzer
  • Ci::PartitioningIdAnalyzer

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Max Orefice

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 2 Warnings
    :warning: 940f38cd: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    :warning: Please add a merge request subtype to this merge request.
    2 Messages
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    :book: This merge request adds or changes files that require a review from the Database team.

    This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

    1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
    2. Prepare your MR for database review according to the docs.
    3. Assign and mention the database reviewer suggested by Reviewer Roulette.

    The following files require a review from the Database team:

    • lib/gitlab/database/query_analyzers/ci/partitioning_routing_analyzer.rb
    • lib/gitlab/database/query_analyzers/ci/partitioning_id_analyzer.rb

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Niko Belokolodov current availability (@nbelokolodov) (UTC+13, 12 hours ahead of @morefice) Vitali Tatarintev current availability (@ck3g) (UTC+1, same timezone as @morefice)
    database Pavel Shutsin current availability (@pshutsin) (UTC+1, same timezone as @morefice) Krasimir Angelov current availability (@krasio) (UTC+13, 12 hours ahead of @morefice)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Max Orefice added 1 commit

    added 1 commit

    Compare with previous version

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 6d7a896c

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Verify | 45     | 0      | 8       | 6     | 53    | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 45     | 0      | 8       | 6     | 53    | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 8aabe3e0

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Create               | 320    | 0      | 10      | 2     | 330   | ❗     |
    | Manage               | 136    | 0      | 26      | 4     | 162   | ❗     |
    | Verify               | 82     | 0      | 16      | 0     | 98    | ✅     |
    | Version sanity check | 0      | 0      | 2       | 2     | 2     | ➖     |
    | Govern               | 82     | 0      | 0       | 2     | 82    | ❗     |
    | Plan                 | 120    | 0      | 0       | 0     | 120   | ✅     |
    | Analytics            | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Configure            | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Secure               | 14     | 0      | 2       | 2     | 16    | ❗     |
    | ModelOps             | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Package              | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Fulfillment          | 4      | 0      | 30      | 0     | 34    | ✅     |
    | Release              | 10     | 0      | 0       | 0     | 10    | ✅     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 772    | 0      | 100     | 12    | 872   | ❗     |
    +----------------------+--------+--------+---------+-------+-------+--------+
  • Grzegorz Bizon requested review from @grzesiek

    requested review from @grzesiek

  • Max Orefice
  • Max Orefice changed the description

    changed the description

  • Max Orefice marked this merge request as ready

    marked this merge request as ready

  • Max Orefice marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Max Orefice changed title from Resolve "Enable Ci::PartitioningAnalyzer" to Enable Ci::PartitioningAnalyzer

    changed title from Resolve "Enable Ci::PartitioningAnalyzer" to Enable Ci::PartitioningAnalyzer

  • Max Orefice added 869 commits

    added 869 commits

    Compare with previous version

  • added workflowin review label and removed workflowin dev label

  • Max Orefice
  • Max Orefice requested review from @mbobin

    requested review from @mbobin

  • Marius Bobin
  • Marius Bobin removed review request for @mbobin

    removed review request for @mbobin

  • Max Orefice added 1 commit

    added 1 commit

    Compare with previous version

  • Max Orefice marked this merge request as draft

    marked this merge request as draft

  • Max Orefice added 1 commit

    added 1 commit

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • 0a834ca9 - Do not check for partition_id presence in dev or test env

    Compare with previous version

  • Marius Bobin mentioned in epic &7522

    mentioned in epic &7522

  • Max Orefice added 1 commit

    added 1 commit

    • c75a7b5a - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • 5f013709 - Do not run analyzer for partition_id

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • e73e8f54 - Split partition analyzer in 2

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • fe10d857 - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • 76469ea7 - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • e49cbaa7 - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice changed milestone to %15.7

    changed milestone to %15.7

  • Max Orefice added 1 commit

    added 1 commit

    • bf88c387 - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • 638dbcc4 - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice added 2 commits

    added 2 commits

    • baf857c4 - Enable Ci::PartitioningAnalyzer
    • f3685052 - Split partition analyzer in 2

    Compare with previous version

  • Max Orefice marked this merge request as ready

    marked this merge request as ready

  • Max Orefice changed the description

    changed the description

  • Max Orefice
  • Max Orefice requested review from @mbobin

    requested review from @mbobin

  • Marius Bobin approved this merge request

    approved this merge request

  • :wave: @mbobin, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Marius Bobin removed review request for @mbobin

    removed review request for @mbobin

  • Max Orefice changed milestone to %15.6

    changed milestone to %15.6

  • Grzegorz Bizon
  • Grzegorz Bizon removed review request for @grzesiek

    removed review request for @grzesiek

  • Max Orefice added 698 commits

    added 698 commits

    Compare with previous version

  • Max Orefice requested review from @grzesiek

    requested review from @grzesiek

  • Grzegorz Bizon removed review request for @grzesiek

    removed review request for @grzesiek

  • Max Orefice requested review from @grzesiek

    requested review from @grzesiek

  • Max Orefice added 1 commit

    added 1 commit

    • 00fba0de - Enable Ci::PartitioningAnalyzer

    Compare with previous version

  • Max Orefice added 249 commits

    added 249 commits

    Compare with previous version

  • Max Orefice added 172 commits

    added 172 commits

    Compare with previous version

  • Grzegorz Bizon resolved all threads

    resolved all threads

  • Grzegorz Bizon
  • Grzegorz Bizon removed review request for @grzesiek

    removed review request for @grzesiek

  • Max Orefice requested review from @grzesiek

    requested review from @grzesiek

  • Grzegorz Bizon resolved all threads

    resolved all threads

  • Grzegorz Bizon approved this merge request

    approved this merge request

  • Grzegorz Bizon enabled an automatic merge when the pipeline for 27eae147 succeeds

    enabled an automatic merge when the pipeline for 27eae147 succeeds

  • Grzegorz Bizon resolved all threads

    resolved all threads

  • Grzegorz Bizon mentioned in commit f1a75a3c

    mentioned in commit f1a75a3c

  • removed database label

  • added database label

  • Grzegorz Bizon resolved all threads

    resolved all threads

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #377535 (closed)

  • mentioned in merge request mbobin/headway!1 (closed)

  • Please register or sign in to reply
    Loading