Enable Ci::PartitioningAnalyzer
Ref: #377535 (closed)
What does this MR do and why?
This MR enables Ci::PartitioningAnalyzer
analyzer to make sure all queries targeting ci_builds_metadata
are now using the routing table for development and testing environment.
In order to accomplish this, I decided to split our existing analyzer in 2 as this was causing many spec failures to disable on feature flag for testing environment.
Ci::PartitioningRoutingAnalyzer
Ci::PartitioningIdAnalyzer
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.6
assigned to @morefice
added workflowin dev label and removed workflowready for development label
- A deleted user
added feature flag label
- Resolved by Max Orefice
2 Warnings 940f38cd: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Please add a merge request subtype to this merge request. 2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
lib/gitlab/database/query_analyzers/ci/partitioning_routing_analyzer.rb
lib/gitlab/database/query_analyzers/ci/partitioning_id_analyzer.rb
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Niko Belokolodov (
@nbelokolodov
) (UTC+13, 12 hours ahead of@morefice
)Vitali Tatarintev (
@ck3g
) (UTC+1, same timezone as@morefice
)database Pavel Shutsin (
@pshutsin
) (UTC+1, same timezone as@morefice
)Krasimir Angelov (
@krasio
) (UTC+13, 12 hours ahead of@morefice
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 6d7a896cexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Verify | 45 | 0 | 8 | 6 | 53 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 45 | 0 | 8 | 6 | 53 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 8aabe3e0expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 320 | 0 | 10 | 2 | 330 | ❗ | | Manage | 136 | 0 | 26 | 4 | 162 | ❗ | | Verify | 82 | 0 | 16 | 0 | 98 | ✅ | | Version sanity check | 0 | 0 | 2 | 2 | 2 | ➖ | | Govern | 82 | 0 | 0 | 2 | 82 | ❗ | | Plan | 120 | 0 | 0 | 0 | 120 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 14 | 0 | 2 | 2 | 16 | ❗ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Fulfillment | 4 | 0 | 30 | 0 | 34 | ✅ | | Release | 10 | 0 | 0 | 0 | 10 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 772 | 0 | 100 | 12 | 872 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
removed [deprecated] Accepting merge requests label
requested review from @grzesiek
- Resolved by Max Orefice
mentioned in issue mbobin/headway#1 (closed)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 869 commits
-
8aabe3e0...725a4e75 - 868 commits from branch
master
- a9528a37 - Enable Ci::PartitioningAnalyzer
-
8aabe3e0...725a4e75 - 868 commits from branch
added workflowin review label and removed workflowin dev label
- Resolved by Max Orefice
requested review from @mbobin
- Resolved by Max Orefice
removed review request for @mbobin
added 1 commit
- 0a834ca9 - Do not check for partition_id presence in dev or test env
- A deleted user
added database databasereview pending labels
mentioned in epic &7522
changed milestone to %15.7
added 2 commits
- Resolved by Max Orefice
- Resolved by Max Orefice
@mbobin could you review this MR please?
requested review from @mbobin
@mbobin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @mbobin
changed milestone to %15.6
- Resolved by Max Orefice
- Resolved by Max Orefice
@morefice Looks good to me! I think splitting the analyzer into two makes sense to me! I left just one question to better understand one detail.
removed review request for @grzesiek
added 698 commits
-
f3685052...ad10717f - 695 commits from branch
master
- 4a977d19 - Enable Ci::PartitioningAnalyzer
- 877b5d72 - Split partition analyzer in 2
- 6d7a896c - Add analyzer in prod behind ff
Toggle commit list-
f3685052...ad10717f - 695 commits from branch
requested review from @grzesiek
- Resolved by Max Orefice
- Resolved by Grzegorz Bizon
One last question @morefice!
removed review request for @grzesiek
requested review from @grzesiek
added 249 commits
-
00fba0de...81d45e21 - 248 commits from branch
master
- 8e551e80 - Enable Ci::PartitioningAnalyzer
-
00fba0de...81d45e21 - 248 commits from branch
added 172 commits
-
8e551e80...6ede0c62 - 171 commits from branch
master
- 940f38cd - Enable Ci::PartitioningAnalyzer
-
8e551e80...6ede0c62 - 171 commits from branch
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
@morefice I have one additional question!
removed review request for @grzesiek
requested review from @grzesiek
- Resolved by Grzegorz Bizon
enabled an automatic merge when the pipeline for 27eae147 succeeds
mentioned in commit f1a75a3c
- Resolved by Grzegorz Bizon
@morefice After merging this MR I noticed that it has databasereview pending label. Should we also ask @stomlinson to review it?
removed database label
removed databasereview pending label
added database label
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in issue #377535 (closed)
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added Category:Continuous Integration label
mentioned in merge request mbobin/headway!1 (closed)
mentioned in merge request gitlab-org/ci-cd/ops-eng-managers/headway!1 (merged)