Refactor Gitlab::Elastic::Helper #create_index

What does this MR do and why?

This is a small refactoring MR to make Gitlab::Elastic::Helper#create_index method arguments safer to use. Right now it's easy to accidentally switch arguments due to them being hashes and strings. This also makes arguments within this class more uniform.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.