Skip to content

Add ability to toggle sidebars on new/edit on-demand-scans

Artur Fedorov requested to merge 379225-ability-to-toggle-sidebars-on-demand-scans into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR resolves #379225 (closed)

Now new/edit On-Demand Scans form and DAST configuration form has 2 sidebars

pre_scan_verification_sidebar.vue

dast_profiles_sidebar.vue

User can open both. So sidebar that was opened later will cover initially opened sidebar.

This MR should add possibility to toggle sidebars, when one opens, another closes.

This was implemented using $refs.sidebar.closeSidebar() $refs.sidebar.openSidebar()

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

before
before
after
after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable flag by enabling rails console in terminal
   Feature.enable(:dast_pre_scan_verification)
  1. Go to BASE_URL/PROJECT_ID/-/on_demand_scans/new
  2. Select scanner|site profile, sidebar is opened
  3. Select view results on pre-scan verification section
  4. First sidebar should be closed pre-scan verification sidebar is opened

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #379225 (closed)

Edited by Ali Ndlovu

Merge request reports