Skip to content

Fix missing feature flag check in Vue vertical menu

Tomas Bulva requested to merge fix-for-vert-menu-missing-ff into master

What does this MR do and why?

This is a fix for the missing feature flag in the vertical menu. It's causing a double-scope menu when the FF is disabled.

6/7 add vertical navigation vue app

Screenshots or screen recordings

When Feature.disable(:search_page_vertical_nav)

before after
Screenshot_2022-10-31_at_14.54.22 image

How to set up and validate locally

  1. checkout this branch
  2. enable feature flag Feature.enable(:search_page_vertical_nav)
  3. search any term on search page http://127.0.0.1:3000/search
  4. disable feature flag Feature.disable(:search_page_vertical_nav)
  5. search any term on search page http://127.0.0.1:3000/search
  6. under both scenarios only one scope menu should be visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #293740 (closed)

Edited by Tomas Bulva

Merge request reports