Skip to content

Fix MR notes not showing author badges

Paul Slaughter requested to merge 379375-fix-mr-not-showing-author-badges into master

What does this MR do and why?

This MR fixes MR notes not showing author badges when signed out (#379375 - closed) by adding a null check ?.. We also add some missing tests.

Screenshots or screen recordings

Before (on master) After (this MR)
Screenshot Screen_Shot_2022-10-30_at_12.15.06_PM

How to set up and validate locally

  1. Don't sign into local GDK
  2. Visit a public MR with notes

Expectation:

  • Note author badges are visible
  • No console errors about reading properties of null should be thrown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #379375 (closed)

Edited by Paul Slaughter

Merge request reports