Skip to content

Move building of pipeline metadata to its own step in chain

Reuben Pereira requested to merge rp/pipeline-title-refactor-chain-populate into master

What does this MR do and why?

Describe in detail what your merge request does and why.

As suggested in !101399 (comment 1147850925), create a Chain::PopulateMetadata class and add it to the chain of steps in CreatePipelineService. Move the building of the Ci::PipelineMetadata model from the Chain::Populate class to the Chain::PopulateMetadata class.

This MR also makes sure that the chain is broken (pipeline creation errors out) if there is an error in the Ci::PipelineMetadata model.

#372538 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Error message that appears on UI when the pipeline name is invalid:

Screenshot_from_2022-10-28_16-31-25

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Furkan Ayhan

Merge request reports