Skip to content
Snippets Groups Projects

Migrate trial's namespace selector away from select2

Merged Paul Gascou-Vaillancourt requested to merge 374095-select2-trial-group-select into master
All threads resolved!

What does this MR do and why?

This migrates the trial namespace selector away from select2 in favor of GlListbox.

Screenshots or screen recordings

Before After
Nothing selected Screen_Shot_2022-11-01_at_8.01.52_AM Screen_Shot_2022-11-01_at_8.00.44_AM
Create group selected Screen_Shot_2022-11-01_at_8.03.06_AM Screen_Shot_2022-11-01_at_8.00.58_AM
Existing group selected Screen_Shot_2022-11-01_at_8.03.24_AM Screen_Shot_2022-11-01_at_8.01.21_AM
Dropdown open Screen_Shot_2022-11-01_at_8.04.00_AM Screen_Shot_2022-11-03_at_8.11.28_AM

How to set up and validate locally

  1. Apply the following patch to ensure you can access the affected page.

    diff --git a/ee/app/controllers/trials_controller.rb b/ee/app/controllers/trials_controller.rb
    index 46770eb524a..51d5144f660 100644
    --- a/ee/app/controllers/trials_controller.rb
    +++ b/ee/app/controllers/trials_controller.rb
    @@ -10,12 +10,12 @@ class TrialsController < ApplicationController
     
       layout 'minimal'
     
    -  before_action :check_if_gl_com_or_dev
    -  before_action :authenticate_user!, except: [:create_hand_raise_lead]
    -  before_action :authenticate_user_404!, only: [:create_hand_raise_lead]
    -  before_action :find_or_create_namespace, only: :apply
    -  before_action :find_namespace, only: [:extend_reactivate, :create_hand_raise_lead]
    -  before_action :authenticate_namespace_owner!, only: [:extend_reactivate]
    +  # before_action :check_if_gl_com_or_dev
    +  # before_action :authenticate_user!, except: [:create_hand_raise_lead]
    +  # before_action :authenticate_user_404!, only: [:create_hand_raise_lead]
    +  # before_action :find_or_create_namespace, only: :apply
    +  # before_action :find_namespace, only: [:extend_reactivate, :create_hand_raise_lead]
    +  # before_action :authenticate_namespace_owner!, only: [:extend_reactivate]
       before_action only: [:new, :select] do
         push_frontend_feature_flag(:gitlab_gtm_datalayer, type: :ops)
       end
  2. Navigate to http://gdk.test:3000/-/trials/select

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #374095 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added UX label

  • Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.

    This message was generated automatically. You're welcome to improve it.

  • added 1 commit

    • 9cebd9e5 - Migrate trial's namespace selector away from select2

    Compare with previous version

  • requested review from @kcomoli

  • added 1 commit

    • 92b86daf - Migrate trial's namespace selector away from select2

    Compare with previous version

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 7c18f4f8 and 37e154b8

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.52 MB 3.52 MB - 0.0 %
    mainChunk 1.95 MB 1.95 MB - 0.0 %

    :fearful: Significant Growth: 2

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.trials.apply 82.99 KB 272.4 KB +189.41 KB 228.2 %
    pages.trials.select 91.17 KB 280.58 KB +189.41 KB 207.7 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @mikegreiling, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 7c18f4f8. So we have used data from: ca301b66.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • added 1 commit

    • 10aee78e - Migrate trial's namespace selector away from select2

    Compare with previous version

  • added 1 commit

    • e6f34183 - Migrate trial's namespace selector away from select2

    Compare with previous version

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 37e154b8

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Manage                             | 39     | 0      | 4       | 7     | 43    | ❗     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern                             | 15     | 0      | 5       | 3     | 20    | ❗     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 152    | 0      | 15      | 10    | 167   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • added 590 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Paul Gascou-Vaillancourt changed the description

    changed the description

  • Kevin Comoli approved this merge request

    approved this merge request

  • :wave: @kcomoli, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Kevin Comoli removed review request for @kcomoli

    removed review request for @kcomoli

  • added 67 commits

    Compare with previous version

  • requested review from @Quintasan and @andrei.zubov

  • Andrei Zubov
  • Andrei Zubov removed review request for @andrei.zubov

    removed review request for @andrei.zubov

  • Paul Gascou-Vaillancourt removed review request for @Quintasan

    removed review request for @Quintasan

  • added 1421 commits

    • 379ceca8...b389de39 - 1419 commits from branch master
    • 693c01ef - Migrate trial's namespace selector away from select2
    • 39aefd43 - Delegate more logic to Vue app & don't touch main bundle

    Compare with previous version

  • Andrei Zubov requested review from @andrei.zubov

    requested review from @andrei.zubov

  • added 331 commits

    • 39aefd43...7de99fb4 - 327 commits from branch master
    • 2aa95d84 - Migrate trial's namespace selector away from select2
    • 5b19eaa1 - Delegate more logic to Vue app & don't touch main bundle
    • 9f76bf6d - Move 'New group name' field to Vue component
    • 55f94f4d - Add tests and clean up

    Compare with previous version

  • removed review request for @andrei.zubov

  • added 344 commits

    Compare with previous version

  • mentioned in merge request !104141 (merged)

  • added 5 commits

    • 55de853d...a487280d - 2 commits from branch master
    • 62245a1d - Disable @gitlab/require-i18n-strings in all stories
    • a4985fe4 - Create ListboxInput component
    • e7dd0ef0 - Migrate trial's namespace selector away from select2

    Compare with previous version

  • Paul Gascou-Vaillancourt changed target branch from master to 374095-select2-trial-group-select-listbox-input

    changed target branch from master to 374095-select2-trial-group-select-listbox-input

  • 🤖 GitLab Bot 🤖 changed milestone to %15.7

    changed milestone to %15.7

  • Paul Gascou-Vaillancourt deleted the 374095-select2-trial-group-select-listbox-input branch. This merge request now targets the master branch

    deleted the 374095-select2-trial-group-select-listbox-input branch. This merge request now targets the master branch

  • added 2820 commits

    Compare with previous version

  • requested review from @andrei.zubov

  • added 134 commits

    Compare with previous version

  • added 117 commits

    Compare with previous version

  • added 303 commits

    Compare with previous version

  • Andrei Zubov approved this merge request

    approved this merge request

  • That looks great @pgascouvaillancourt ! Thanks for all the work you've put into it :smile: I am passing it over for a maintainer review.

    @afontaine could you please help reviewing it?

  • Andrei Zubov requested review from @afontaine and removed review request for @andrei.zubov

    requested review from @afontaine and removed review request for @andrei.zubov

  • added 1537 commits

    Compare with previous version

  • Andrew Fontaine resolved all threads

    resolved all threads

  • Andrew Fontaine approved this merge request

    approved this merge request

  • This looks good to me, thanks @pgascouvaillancourt

  • Andrew Fontaine enabled an automatic merge when the pipeline for aa75589d succeeds

    enabled an automatic merge when the pipeline for aa75589d succeeds

  • Andrew Fontaine mentioned in commit a8bd020d

    mentioned in commit a8bd020d

  • added workflowstaging label and removed workflowcanary label

  • mentioned in merge request !107392 (merged)

  • mentioned in merge request !107516 (merged)

  • Please register or sign in to reply
    Loading