Skip to content

Remove ambiguous reference specs

James Fargher requested to merge remove_ambiguous_ref_tests into master

What does this MR do and why?

gitaly#4031 (closed)

These tests were making gitaly return GRPC internal errors. This is roughly equivalent to a HTTP 500 error. We should not be relying on such behaviour. The fix for this gitaly!4969 (merged) cannot be released while these tests exist as all specs are run as part of the gitaly update.

The new error in the fix is already covered via the tests for an already existing ref.

The gitaly team have effectively decided that there should not be tests of git internals in gitlab-rails tests, as long as there are equivalent tests in gitaly itself. So while we will temporarily loose coverage here, we will gain gitaly coverage via gitaly!4969 (merged).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by James Fargher

Merge request reports