Skip to content

Add `shared_runners_minutes_limit` to project settings

Anatoli Babenia requested to merge abitrolly/gitlab:project-ci-cd-minutes-limit into master

Moved to !121240 (closed) (community fork).

What does this MR do and why?

Adds shared_runners_minutes_limit field to project CI/CD settings for Set CI/CD limit for projects within a sub-group... (#351147)

It takes a while as my knowledge of Ruby/Rails is pretty basic. I document my contributor experience over this feature in https://gitlab.com/-/snippets/2434344+

TODO (not this MR):

  • find a place where an instance or namespace's shared_runners_minutes_limit is checked and add project's shared_runners_minutes_limit check there
  • expose getting/setting through API
  • add UI to view/change/unset the value

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. In rails console check that project setting field exists and it is nil. 
    Project.first.ci_cd_settings.shared_runners_minutes_limit

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Anatoli Babenia

Merge request reports