Skip to content

Backward compatible behavior in alert management client side router

Dannyel Cardoso da Fonseca requested to merge dannyelcf/gitlab:374724-dcf-backward-compatible-behavior-alert-management-client-side-router into master

What does this MR do and why?

Keeps backward-compatible behavior for users who linked the "hash form" URLs somewhere. So,

<base>/root/test-proj/-/alert_management/1/details#/overview is "redirect" to <base>/root/test-proj/-/alert_management/1/details/overview.

<base>/root/test-proj/-/alert_management/1/details#/metrics is "redirect" to <base>/root/test-proj/-/alert_management/1/details/metrics.

<base>/root/test-proj/-/alert_management/1/details#/activity is "redirect" to <base>/root/test-proj/-/alert_management/1/details/activity.

Screenshots or screen recordings

Recording_2022-10-22_at_13.03.16

How to set up and validate locally

  1. In a project, create HTTP alerts from the menu Settings > Monitor > Alerts > Current integrations (Tab) > HTTP row > Settings (Actions Icon) > Send test alert (Tab) > Send (Button)
  1. Go to the menu Monitor > Alerts and click on the new created alert.
  2. Navigate between the tabs Alert details, Metrics and Activity feed and check the URL changes.
  3. Use the forward/back buttons of the browser.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #374724 (closed)

Edited by Dannyel Cardoso da Fonseca

Merge request reports