Mask the "Secret token" input in the webhook form
What does this MR do and why?
Original credit to !90670 (closed). Issue #359989 (closed).
This MR makes the Secret token
field a password-like field:
- It hides input when you create the webhook.
- It does not show the field once saved and only shows 12 stars
************
for the field. To keep the current value, you just leave it as-is.
Screenshots or screen recordings
Screen recording
Screenshots
Page | Before | After |
---|---|---|
Index | ||
Edit |
How to set up and validate locally
- Go to Project > Settings > Webhooks. For example,
http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/hooks
. - Fill in the
URL
andSecret token
fields. - Observe that the
Secret token
field is now masked as a password field. On webhook edit, this field is completely hidden. - Check the values in the
rails console
to make sure the right one is saved.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Justin Ho Tuan Duong