Skip to content

feat: Include resolution comment when auto-resolving vulnerabilities

What does this MR do and why?

As a follow-up to !95422 (merged), we now have the capability to auto-resolve vulnerabilities when an analyzer has removed their vulnerability type from our default scanner rulesets. To better describe the automation we should include a clear comment describing the auto-resolution.

This feature is currently behind feature flag see rollout issue: #375128 (closed)

Screenshots or screen recordings

Before After
Screen_Shot_2022-10-31_at_16.11.29 Screen_Shot_2022-10-31_at_15.55.57

How to set up and validate locally

Test project export using modified fixtures: 2022-08-16_16-45-709_root_go_export.tar.gz

  1. Enable the feature flag: Feature.enable(:sec_mark_dropped_findings_as_resolved)
  2. Run default pipeline
  3. Confirm presence of 3 vulnerabilities on dashboard
  4. Update .gitlab-ci.yml to reference gl-sast-report.tests-go-with-scan-primary-identifiers.json
  5. Confirm no change in behavior (still 3 vulnerabilities on dashboard)
  6. Update .gitlab-ci.yml to reference gl-sast-report.tests-go-with-scan-primary-identifiers-dropping-G104.json
  7. Confirm auto-resolution of dropped identifier (2 remaining detected vulnerabilities, 1 resolved and no longer detected)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lucas Charles

Merge request reports