Skip to content

Show only active users on Starrers page of a project

Jonas Wälter requested to merge siemens/gitlab:project-starrers/active-users-only into master

What does this MR do and why?

On the Starrers page of a project (e.g. https://gitlab.com/gitlab-org/gitlab/-/starrers), all starring users are shown - even blocked or other non-active users. With this MR, only active users are shown on the Starrers page of a project.

Related issue: Do not count stars of blocked users (!100023 - merged)

🛠 with ❤ at Siemens

/cc @bufferoverflow

Screenshots or screen recordings

Before MR After MR
image image

How to set up and validate locally

  1. Star a project as a user (http://localhost:3000/twitter/Typeahead.Js):
user = User.find(17)
project = Project.find(7)
user.toggle_star(project)
  1. Navigate to the Starrers page of the project (http://localhost:3000/twitter/Typeahead.Js/-/starrers) and verify that the user is shown.
  2. Block the user:
user.block!
  1. Navigate to the Starrers page of the project and verify that the user is NOT shown.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports