Skip to content

Add curly brackets to fix failing specs in ruby 3

Roy Zwambag requested to merge 378379-fix-cluster_reindexing_service_spec-ruby3 into master

Fixes https://gitlab.com/gitlab-org/gitlab/-/jobs/3192986653

This spec fails in Ruby 3 due to the way rspec-mocks handles hash vs kwargs matching.

Similar to !86157 (merged), see this MR for more context

How to set up and validate locally

Run the spec in both Ruby 2.7.5 (regular way) and Ruby 3.0.4, both should pass

You can run specs in ruby 3 by:

  • Executing asdf local ruby 3.0.4
  • Run the spec

Ruby 3.0 pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/670843867#/

Ruby 2.7 pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/670845275#/

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Fixes #378379 (closed)

Edited by Roy Zwambag

Merge request reports