Skip to content

Improve alert management client-side router usage

Dannyel Cardoso da Fonseca requested to merge dannyelcf/gitlab:374724-dcf-improve-alert-management-client-side-router-usage into master

What does this MR do and why?

In the frontend, it changes the alert management details VueRouter mode from hash to history and in the backend it adapts the route matching to the alert management details endpoint.

Screenshots or screen recordings

Recording_2022-10-19_at_22.30.05

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In a project, create HTTP alerts from the menu Settings > Monitor > Alerts > Current integrations (Tab) > HTTP row > Settings (Actions Icon) > Send test alert (Tab) > Send (Button)
  1. Go to the menu Monitor > Alerts and click on the new created alert.
  2. Navigate between the tabs Alert details, Metrics and Activity feed and check the URL changes.
  3. Use the forward/back buttons of the browser.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #374724 (closed)

Edited by Dannyel Cardoso da Fonseca

Merge request reports