Remove unneeded experiment model layer items
What does this MR do and why?
Removes the ExperimentUser
model and associated code as it is no longer used. Table will be removed in a separate MR as per #349246 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #349246 (closed)
Merge request reports
Activity
changed milestone to %15.5
assigned to @dstull
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@dstull - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
Edited by 🤖 GitLab Bot 🤖
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugie Limpin ( @eugielimpin
) (UTC+8, 12 hours ahead of@dstull
)Jan Provaznik ( @jprovaznik
) (UTC+2, 6 hours ahead of@dstull
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #349246 (closed)
added 662 commits
-
76c0798e...77f58d6a - 661 commits from branch
master
- 1bd3e150 - Remove unused exmod content at model layer
-
76c0798e...77f58d6a - 661 commits from branch
added 4 commits
-
1bd3e150...76abf813 - 3 commits from branch
master
- 05de321c - Remove unused exmod content at model layer
-
1bd3e150...76abf813 - 3 commits from branch
- Resolved by Bob Van Landuyt
@alexbuijs another one for you related to EXMOD if you will please review for backend.
requested review from @alexbuijs
added workflowin review label and removed workflowin dev label
added maintenancerefactor label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 95f9f61aexpand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
requested review from @reprazent and removed review request for @alexbuijs
@alexbuijs
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
oops missed removing factory for
experiment_user
https://gitlab.com/gitlab-org/gitlab/-/jobs/3190335184#L10469. doneadded 295 commits
-
05de321c...69077a24 - 293 commits from branch
master
- dbedf50a - Remove unused exmod content at model layer
- 95f9f61a - Remove experiment_users factory
-
05de321c...69077a24 - 293 commits from branch
changed milestone to %15.6
- Resolved by Bob Van Landuyt
removed review request for @reprazent
requested review from @reprazent
enabled an automatic merge when the pipeline for 5be91671 succeeds
mentioned in commit 270f2e90
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request !102337 (merged)
added releasedpublished label and removed releasedcandidate label