Skip to content

Improve user_sees_avatar_on_diff_notes_spec

Alina Mihaila requested to merge am-improve-users-avatar-on-diff-spec into master

What does this MR do and why?

Related #375006 (closed)

Describe in detail what your merge request does and why.

Before

Finished in 3 minutes 39.3 seconds (files took 12.01 seconds to load)
10 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:27.851 (12.65% of total time)
[TEST PROF INFO] Factories usage

 Total: 47
 Total top-level: 34
 Total time: 00:27.851 (out of 03:44.906)
 Total uniq factories: 6

   total   top-level     total time      time per call      top-level time               name

      13          13        1.0573s            0.0813s             1.0573s diff_note_on_merge_request
      10          10       23.2793s            2.3279s            23.2793s            project
      10           0        0.9236s            0.0924s             0.0000s          namespace
      10          10        3.5054s            0.3505s             3.5054s merge_request_with_diffs
       3           0        0.0006s            0.0002s             0.0000s text_diff_position
       1           1        0.0094s            0.0094s             0.0094s            license

After

Finished in 3 minutes 8.9 seconds (files took 8.63 seconds to load)
10 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:04.619 (2.43% of total time)
[TEST PROF INFO] Factories usage

 Total: 20
 Total top-level: 16
 Total time: 00:04.619 (out of 03:14.394)
 Total uniq factories: 6

   total   top-level     total time      time per call      top-level time               name

      13          13        1.1057s            0.0851s             1.1057s diff_note_on_merge_request
       3           0        0.0006s            0.0002s             0.0000s text_diff_position
       1           1        0.0067s            0.0067s             0.0067s            license
       1           1        2.6267s            2.6267s             2.6267s            project
       1           0        0.1232s            0.1232s             0.0000s          namespace
       1           1        0.8801s            0.8801s             0.8801s merge_request_with_diffs

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports