Skip to content

Bump health_checks gem to v3.1.0

Matthias Käppler requested to merge 377424-health_check-3.1.0 into master

What does this MR do and why?

This is required for Ruby 3 support.

I also rewrote the master_check_spec to not fork in the test suite since I noticed this made tests fail that ran after this spec, though I am not sure why.

The official changes in the gem between the two minor versions are:

  * Updated README to clarify railsN branch status (they are intended to be stable, development to be a feature branch off them or master)
  * Updated README with all the settings
  * Updated all the branches to work with the latest travis and gem changes, as some gems needed to be locked down.
  * Updated to test rails 6.0 and 6.1
  * Got all travis tests passing
  * Removed old, unused branches
  * Merged PR Fix broken Cache-Control headers #93 from felixbuenemann 
  * Merged PR S3 should not depend on Rails secrets file #77 by natefaerber
  * Merged PR RabbitMQ Health check #98 from rhuanbarreto
  * Merged PR Use remote_ip to accept proxy-forwarded requests #102 by alessio-signorini but made it optional
  * Fixed up failure setting to match previous output on error, and use it as a prefix when the error message is also output (not by default)
  * Always log the error to rails log even if not including in html response
  * Merged PR ensure REDIS connections are closed #88 from yld
  * Merged PR more robust cache check #90 from masciugo
  * Merged PR Add log_level config setting which defaults to 'info'. #97 from FloHeinle 
  * Merged PR get rid of old school hash rockets syntax #92 from DmytroStepaniuk
  * Merged PR Converted whitelist testing to use IPAddr objects. #64 jordanyaker
  * Added on_success and on_failure callbacks
  * Makes sure errors are seperated by a period and a space and a period always ends the list of errors

If you look at the actual commits, there were several Ruby 3 related patches as well such as:

Additionally we get upstream test coverage for the version of Rails we use, which is good.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #377424 (closed)

Merge request reports