Skip to content
Snippets Groups Projects

Fix: locale on issue show edited by component

All threads resolved!

What does this MR do and why?

Right now the component shows mixed content on the page which looks quite weird, this MR is meant to fix that by replacing hardcoded texts with externalized texts.

/cc @prajnamas @orozot @qk44077907

Describe in detail what your merge request does and why.

Screenshots or screen recordings

before after
CleanShot_2022-10-10_at_15.19.57_2x CleanShot_2022-10-10_at_15.25.36_2x

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Go to your GDK.
  2. Go to any project.
  3. Find any issue and edit the description right away.
  4. Observe.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Wu Jeremy added 1 commit

    added 1 commit

    • 7eb176ca - Fix: locale on issue show edited by component

    Compare with previous version

  • LGTM.

  • Wu Jeremy marked this merge request as ready

    marked this merge request as ready

  • requested review from @kushalpandya

  • Kushal Pandya removed review request for @kushalpandya

    removed review request for @kushalpandya

  • Kushal Pandya
  • added bugux typebug labels

  • Kushal Pandya approved this merge request

    approved this merge request

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Dominic Couture approved this merge request

    approved this merge request

  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya changed milestone to %15.5

    changed milestone to %15.5

  • Kushal Pandya enabled an automatic merge when the pipeline for 204e02f3 succeeds

    enabled an automatic merge when the pipeline for 204e02f3 succeeds

  • 1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Tristan Read (@tristan.read) (UTC+13) Justin Ho (@justin_ho) (UTC+7)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 0357e40d and 7eb176ca

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.59 MB 3.59 MB - 0.0 %
    mainChunk 1.96 MB 1.96 MB - 0.0 %

    Note: We do not have exact data for 0357e40d. So we have used data from: 60875732.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 7eb176ca

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Plan                               | 53     | 0      | 4       | 1     | 57    | ❗     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Verify                             | 12     | 0      | 1       | 2     | 13    | ❗     |
    | Govern                             | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Manage                             | 52     | 0      | 8       | 3     | 60    | ❗     |
    | Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 158    | 0      | 17      | 8     | 175   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • merged

  • Kushal Pandya mentioned in commit 0c9d4c8a

    mentioned in commit 0c9d4c8a

  • @JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. Leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading