Fix: locale on issue show edited by component
What does this MR do and why?
Right now the component shows mixed content on the page which looks quite weird, this MR is meant to fix that by replacing hardcoded texts with externalized texts.
/cc @prajnamas @orozot @qk44077907
Describe in detail what your merge request does and why.
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Go to your GDK.
- Go to any project.
- Find any issue and edit the description right away.
- Observe.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added JiHu contribution label
Hey @JeremyWuuuuu!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @JeremyWuuuuu
4 Warnings Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. This Merge Request needs to be labelled with frontend. Please request a reviewer or maintainer to add them. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani ( @deepika.guliani
) (UTC+5.5)Jose Ivan Vargas ( @jivanvl
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 5ceadec6 - Fix: locale on issue show edited by component
- Resolved by Kushal Pandya
added 1 commit
- 7eb176ca - Fix: locale on issue show edited by component
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
- Resolved by Kushal Pandya
@kushalpandya
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
requested review from @kushalpandya
added devopsplan frontend groupproject management labels
removed review request for @kushalpandya
added sectiondev label
mentioned in issue gitlab-org/quality/triage-reports#9512 (closed)
- Resolved by Kushal Pandya
mentioned in issue gitlab-jh/status-reports#164
- Resolved by Kushal Pandya
@kushalpandya
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by 🤖 GitLab Bot 🤖
@kushalpandya
, thanks for approving this merge request.This is the first time the merge request has been approved. Please wait for AppSec approval before merging.
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.
added sec-planningcomplete label
changed milestone to %15.5
enabled an automatic merge when the pipeline for 204e02f3 succeeds
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tristan Read ( @tristan.read
) (UTC+13)Justin Ho ( @justin_ho
) (UTC+7)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 0357e40d and 7eb176ca
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.59 MB 3.59 MB - 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 %
Note: We do not have exact data for 0357e40d. So we have used data from: 60875732.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 7eb176caexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 53 | 0 | 4 | 1 | 57 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 1 | 2 | 13 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Manage | 52 | 0 | 8 | 3 | 60 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 158 | 0 | 17 | 8 | 175 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 0c9d4c8a
@JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- Leave a
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-jh/status-reports#166
added releasedcandidate label
mentioned in issue jh-upstream-report#55 (closed)
mentioned in issue jh-upstream-report#55 (closed)
added releasedpublished label and removed releasedcandidate label