Skip to content

[18052] GitHub importer - Scrape images to GitLab and update markdown (Support image tags)

Rostyslav Safonov requested to merge rs-18052-scrape-github-attachments-img-tag into master

What does this MR do and why?

Implementation for a part of GitHub importer - Scrape images to GitLab and update markdown

This particular MR provides ability to import attachments that are inserted in text via <img> tag, not a standard markdown.

  • ![image.jpeg](#{image_url}) <- standard markdown
  • <img width=\"248\" alt=\"tag-image\" src="#{image_tag_url}"> <- img tag

Such case happens from time to time with a special images. I didn't get what is special in such images (I mean why GitHub inserts them as img tag) but I have the one for a test.

feature flag

Screenshots or screen recordings

Local test

How to set up and validate locally

Enable github_importer_attachments_import feature flag. Create project via import from Github. The project should have notes (comments)/release description with attachments. After import make sure that notes/release posts have attachment links that belongs to gitlab server.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rostyslav Safonov

Merge request reports