Edit deploy token tasks to adhere to CTRT convention
What does this MR do?
Edit deploy token tasks to adhere to CTRT convention.
Related issues
Author's checklist
-
Optional. Consider taking the GitLab Technical Writing Fundamentals course. -
Follow the: -
If you're adding or changing the main heading of the page (H1), ensure that the product tier badge is added. -
If you are a GitLab team member, request a review based on: - The documentation page's metadata.
- The associated Technical Writer.
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
~"frontend"
~"backend"
~"type::bug"
~"database"
These labels cause the MR to be added to code verification QA issues.
Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
-
If the content requires it, ensure the information is reviewed by a subject matter expert. - Technical writer review items:
-
Ensure docs metadata is present and up-to-date. -
Ensure the appropriate labels are added to this MR. -
Ensure a release milestone is set. - If relevant to this MR, ensure content topic type principles are in use, including:
-
The headings should be something you'd do a Google search for. Instead of Default behavior
, say something likeDefault behavior when you close an issue
. -
The headings (other than the page title) should be active. Instead of Configuring GDK
, say something likeConfigure GDK
. -
Any task steps should be written as a numbered list. - If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
-
-
-
Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Merge request reports
Activity
changed milestone to %15.5
added docsimprovement documentation maintenancerefactor typemaintenance labels
assigned to @rdickenson
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @stanhu
,@smcgivern
,@tkuah
,@mayra-cabrera
,@marcel.amirault
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
added Technical Writing label
added devopsrelease [DEPRECATED] grouprelease [DEPRECATED] labels
added sectionops label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/packages/dependency_proxy/index.md
doc/user/packages/package_registry/index.md
doc/user/project/deploy_tokens/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @jglassman1
- Resolved by Russell Dickenson
@jglassman1 - Could you please review this MR? I don't think it's worth doing a review build yet, so you can use the following link to preview the content: https://gitlab.com/gitlab-org/gitlab/-/blob/d4c7a907911adcc48851f66c0be1de05a856f011/doc/user/project/deploy_tokens/index.md
It's in draft status because I see room for improvement. It may be a little confusing, but this MR is related to !97905 (merged). The focus of this MR is to make the tasks CTRT compliant. The tasks are intermingled with other topic types, which I expect looks messy. When this and the related MR are merged, the result will be much cleaner.
You may notice several things:
- The tasks are very light on detail.
- Each task has an almost identical structure.
- The useful commands (
push
,pull
, and so on) are missing from the command examples.
As a result of this editing, I've realized it may be better to reformat this content into a table of "things you can do with a deploy token". The following structure may suit:
Function Required scope Example command Pull image from container registry read_registry
docker login -u <username> -p <deploy_token> registry.example.com
However, this creates a table where the example commands are wrapped, which makes it difficult to read. Do you have any ideas on how I could present this better?
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
removed review request for @jglassman1
requested review from @jglassman1
- Resolved by Kati Paizee
@jglassman1 - Could you please review this MR again? I've addressed all your feedback since the previous review. I've also made several more changes in addition:
- Reworded the introductions to the example commands so that it's clear they are examples, not prescribed commands.
- Removed the screenshot of the deploy token's creation form. It didn't seem necessary, given it's a form, and the screenshot didn't help the instructions.
- Moved mention of the scopes into the "Complete the fields." step. The scopes are one of the fields, so it didn't make sense to keep it separate.
- Removed all instances of "For example, as part of a CI/CD pipeline." After reviewing this again, I decided that that's already described in the introduction, so it didn't make sense to repeat it each time.
- Edited the single troubleshooting entry to comply with our CTRT format.
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
- Resolved by Jon Glassman
- Resolved by Russell Dickenson
removed review request for @jglassman1
requested review from @jglassman1
requested review from @kpaizee
- Resolved by Kati Paizee
@kpaizee - Could you please review this MR? Note that before merging this MR, I'll likely need to rebase it against
master
so that it contains all recent changes, including those from the related MR - !97905 (merged).
mentioned in merge request !97905 (merged)
- Resolved by Russell Dickenson
- Resolved by Russell Dickenson
@rdickenson LGTM! Just made 2 more very small suggestions, but feel free to ignore them.
removed review request for @jglassman1
- Resolved by Kati Paizee
- Resolved by Kati Paizee
removed review request for @kpaizee
mentioned in issue technical-writing#579
added 1035 commits
-
5b20d88d...6c79fa58 - 1023 commits from branch
master
- b9f026bf - Edit tasks to CTRT style
- c03a33ee - Fix broken links
- 434e9e4c - Remove unwanted asterisk
- 3f91053f - Apply 6 suggestion(s) to 1 file(s)
- cd7f5db8 - Edit per review feedback
- 64fa9c6d - Improve troubleshooting entry
- b654c2bb - Edit per self review
- b7131d9f - Apply 2 suggestion(s) to 1 file(s)
- 05d0b8c2 - Edits per review feedback
- 264ca80b - Edits per review feedback
- 519144cc - Edits per self review
- 9228843d - Edits per self review
Toggle commit list-
5b20d88d...6c79fa58 - 1023 commits from branch
requested review from @kpaizee
enabled an automatic merge when the pipeline for 105e9bfa succeeds
mentioned in commit 8afd2c89
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label