Skip to content
Snippets Groups Projects

Edit deploy token tasks to adhere to CTRT convention

Merged Russell Dickenson requested to merge russell/ctrt-deploy-tokens-part2 into master
All threads resolved!

What does this MR do?

Edit deploy token tasks to adhere to CTRT convention.

Related issues

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Russell Dickenson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jon Glassman removed review request for @jglassman1

    removed review request for @jglassman1

  • added 1 commit

    • f4bedadb - Apply 6 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 137146fd - Improve troubleshooting entry

    Compare with previous version

  • Russell Dickenson resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • requested review from @jglassman1

    • Resolved by Kati Paizee

      @jglassman1 - Could you please review this MR again? I've addressed all your feedback since the previous review. I've also made several more changes in addition:

      • Reworded the introductions to the example commands so that it's clear they are examples, not prescribed commands.
      • Removed the screenshot of the deploy token's creation form. It didn't seem necessary, given it's a form, and the screenshot didn't help the instructions.
      • Moved mention of the scopes into the "Complete the fields." step. The scopes are one of the fields, so it didn't make sense to keep it separate.
      • Removed all instances of "For example, as part of a CI/CD pipeline." After reviewing this again, I decided that that's already described in the introduction, so it didn't make sense to repeat it each time.
      • Edited the single troubleshooting entry to comply with our CTRT format.
  • Jon Glassman
  • Jon Glassman
  • Jon Glassman removed review request for @jglassman1

    removed review request for @jglassman1

  • added 1 commit

    • 4584ffcd - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • requested review from @jglassman1

  • Russell Dickenson requested review from @kpaizee

    requested review from @kpaizee

  • Russell Dickenson changed the description

    changed the description

  • Russell Dickenson mentioned in merge request !97905 (merged)

    mentioned in merge request !97905 (merged)

  • @rdickenson LGTM! Just made 2 more very small suggestions, but feel free to ignore them.

  • Jon Glassman approved this merge request

    approved this merge request

  • Jon Glassman removed review request for @jglassman1

    removed review request for @jglassman1

  • Kati Paizee
  • Kati Paizee
  • Kati Paizee removed review request for @kpaizee

    removed review request for @kpaizee

  • Russell Dickenson added 1035 commits

    added 1035 commits

    Compare with previous version

  • Russell Dickenson marked this merge request as ready

    marked this merge request as ready

  • Russell Dickenson changed title from Draft: Edit deploy token tasks to CTRT style to Edit deploy token tasks to adhere to CTRT convention

    changed title from Draft: Edit deploy token tasks to CTRT style to Edit deploy token tasks to adhere to CTRT convention

  • Russell Dickenson changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • Russell Dickenson requested review from @kpaizee

    requested review from @kpaizee

  • Kati Paizee approved this merge request

    approved this merge request

  • Kati Paizee resolved all threads

    resolved all threads

  • Kati Paizee enabled an automatic merge when the pipeline for 105e9bfa succeeds

    enabled an automatic merge when the pipeline for 105e9bfa succeeds

  • merged

  • Kati Paizee mentioned in commit 8afd2c89

    mentioned in commit 8afd2c89

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading