Resolve "Add missing snowplow tracking to primary navigation"

changed milestone to %15.5

added frontend groupfoundations navigation sectiondev snowplow tracking events typemaintenance + 1 deleted label

Proper labels assigned to this merge request. Please ignore me.

@mikegreiling - please see the following guidance and update this merge request.

	1 Warning
	Please add a subtype label to this merge request.

If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.

added 1 commit

129e83fe - Add snowplow event tracking to hamburger menu toggle

Compare with previous version

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
`@dbalexandre`, `@rob.hunt`, `@felipe_artur`, `@ntepluhina`, `@f_caplette`

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Sharmad Nachnolkar (`@snachnolkar`) (UTC+5.5, 10.5 hours ahead of `@mikegreiling`)	Jose Ivan Vargas (`@jivanvl`) (UTC-5, same timezone as `@mikegreiling`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 8eb09da2 and 59c0ec58

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.59 MB	3.59 MB	-	0.0 %
mainChunk	1.96 MB	1.96 MB	-	0.0 %

Note: We do not have exact data for 8eb09da2. So we have used data from: 77f58d6a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 59c0ec58

expand test summary

+-----------------------------------------------------------------------------------------+
|                                     suites summary                                      |
+------------------------------------+--------+--------+---------+-------+-------+--------+
|                                    | passed | failed | skipped | flaky | total | result |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Manage                             | 52     | 0      | 8       | 2     | 60    | ❗     |
| Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
| Plan                               | 47     | 0      | 1       | 0     | 48    | ✅     |
| Govern                             | 2      | 0      | 0       | 0     | 2     | ✅     |
| Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
| Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
| Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure                             | 2      | 0      | 0       | 0     | 2     | ✅     |
| Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
| Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Total                              | 152    | 0      | 14      | 2     | 166   | ❗     |
+------------------------------------+--------+--------+---------+-------+-------+--------+

trying to work out how I could add a test for this…

added 390 commits

129e83fe...08470331 - 389 commits from branch master
17a40b79 - Add snowplow event tracking to hamburger menu toggle

Compare with previous version

added 1 commit

64b1a011 - Add test for tracking event in top nav toggle

Compare with previous version

Note to reviewer: the toggle event does not appear to be triggered when the dropdown is closed by clicking elsewhere on the page. I don't see any good way around this without forking the bootstrap BNavItemDropdown class which seems wildly out of scope here.