Skip to content

Fix alignment on changed line in multiline suggestion comment

Annabel Dunstone Gray requested to merge changed-line-diff-alignment into master

What does this MR do and why?

Fixed alignment on multiline suggestion comments that were not applied, but changed by someone other than the commenter

Screenshots or screen recordings

Before After
Screen_Shot_2022-10-04_at_12.33.17_PM Screen_Shot_2022-10-04_at_12.33.39_PM

How to set up and validate locally

  1. Go to MR
  2. Create multiline comment with a suggestion
  3. Impersonate a user with merge permissions on that project
  4. Change the line of code that was commented on (or remove it entirely) - do not apply the suggestion or make the same change as the suggestion
  5. Commit changes
  6. Stop impersonating
  7. Look at activity entry on MR

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports