Test plan for "Multiple approval groups/rules"

Introduction

This test plan is for https://gitlab.com/gitlab-org/gitlab-ee/issues/1979. The feature allows approval to be required from multiple rules, where a rule is a group (or lists of users) and a number indicating the number of required approvals.

Scope

  • EE-only (Starter and Premium)

ACC Matrix

Secure Responsive Intuitive Reliable
Project
MRs
Settings
API

For more information see the Google Testing Blog article about the 10 minute test plan and this wiki page from an open-source tool that implements the ACC model.

Capabilities

Settings are:

  • Intuitive
    • Rules can be specified in the Project settings
  • Reliable
    • It's not possible to require more approvals than there are users specified in a rule. I.e., if a rule lists 2 users it should not be possible to require 3 approvals from that group.

MRs are:

  • Intuitive
    • If project settings allow overriding approvers, the list of approvers and number of approvals can be modified.
    • Authors can self-approve if the setting is enabled and they are in one of the rules.

Test Plan

Test Coverage sheet

Edited Jun 26, 2025 by 🤖 GitLab Bot 🤖
Assignee Loading
Time tracking Loading