Remove FF advanced_vulnerability_management

Summary

This issue is to cleanup the advanced_vulnerability_management feature flag.

The feature flag has been stable since %18.2 and was default enabled same milestone with !193929 (merged)

Considerations

• Before removing this FF, we have to support the same use-case with an ops-type FF so in future if we want to test something on gitlab.com with PG and not using ES we need a toggling flag that works at a project or group level and not an application setting. See discussion !188856 (comment 2486902175)

  • Handled with Use Elasticsearch for all Vulnerability Report ... (#547510)

• Remove the additional preloading logic implemented for vulnerability ingestion to support the ingestion feature flag and which was missed during ingestion feature flag removal.

  • https://gitlab.com/gitlab-org/gitlab/-/blob/0f5d2a4d0266dda43414398b33fa41cad86116aa/ee/app/services/security/ingestion/ingest_slice_base_service.rb#L58
  • https://gitlab.com/gitlab-org/gitlab/-/blob/0f5d2a4d0266dda43414398b33fa41cad86116aa/ee/app/services/vulnerabilities/bulk_es_operation_service.rb#L18-L22

Owners

• Team: groupsecurity infrastructure
• Most appropriate slack channel to reach out to: #g_srm_security_infrastructure
• Best individual to reach out to: @bala.kumar
• PM:

Stakeholders

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

• Specify in the issue description if this feature will be removed completely or will be productized as part of the Feature Flag cleanup
• Create a merge request to remove <feature-flag-name> feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
• Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
• Close the feature issue to indicate the feature will be released in the current milestone.
• If not already done, clean up the feature flag from all environments by running these chatops command in #production channel: /chatops run feature delete <feature-flag-name> --dev --pre --staging --staging-ref --production
• Close this rollout issue.