Skip to content

Part 2 of Allow Geo sync requests even if Git over HTTP is disabled

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Part 1 is #348482 (closed)

Proposal

Geo requires the HTTP(S) git access protocol to be enabled to work. If the HTTP(S) git access protocol is disabled, Geo stops working. As per our Geo requirements:

Geo synchronizes repositories over HTTP/HTTPS, and therefore requires this clone method to be enabled.

GitLab Runners however aren't affected by this limitation (as per the comment in this section)

GitLab versions 10.7 and later, allow the HTTP(S) protocol for Git clone or fetch requests done by GitLab Runner from CI/CD jobs, even if you select Only SSH.

If an admin decides to disable the HTTP(S) git access protocol, then Geo replication should still work.

#348360 (closed) can be closed if this issue is addressed.

Relevant files:

Implementation Plan

#348482 (closed) must be done first.

Documentation and Rake task follow up work (weight 1)

  1. Remove http_clone_enabled_check.rb
  2. Test it yourself locally (at least rake gitlab:geo:check)
  3. Remove a documented step https://docs.gitlab.com/administration/geo/replication/configuration/#step-5-enable-git-access-over-httphttps-and-ssh
Edited by 🤖 GitLab Bot 🤖