Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !18021

Resolve "Allow HTTPS cloning by Runners if it is disabled for users"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tomasz Maczukin requested to merge 44389-always-allow-http-for-ci-git-operations into master Mar 27, 2018
  • Overview 17
  • Commits 3
  • Pipelines 6
  • Changes 6

What does this MR do?

Makes HTTP(s) protocol available for CI clone/fetch, even if it's disabled in general.

Are there points in the code the reviewer needs to double check?

Security. With this change we're changing current implementation of checking if HTTP(s) git operations are enabled. We should ensure, that this change doesn't open any security vulnerabilities.

EE port in gitlab-org/gitlab-ee!5253

Why was this MR needed?

Please look into #44389 (closed) for a reference.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes #44389 (closed)

Edited Apr 05, 2018 by Tomasz Maczukin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 44389-always-allow-http-for-ci-git-operations