Terminology Standardization: Tool to Report Type // Follow-up from "503371 / Rename Tool Header to Report Type on Group Level"
In this issue we will wrap-up the changes made in #503371 (closed). We will:
- Remove all remaining instances of
Toolterminology in vulnerability management interfaces at both Group and Project level. - Create new filter and field presets in
ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/constants.jsto properly distinguish between Group and Project level functionality - Update both
FILTER_PRESETSandFIELD_PRESETSconfigurations to reflect these changes consistently across the application
This work finalizes our terminology standardization by removing all instances of Tool and replacing with Report type throughout vulnerability management.
The following discussion from !181818 (merged) should be addressed:
-
@charlieeekroon started a discussion: (+1 comment) note: I added this extra check to prevent the
scannerfilter from appearing at thegrouplevel. We currently are not handlingscannerfilters ongrouplevel (#515333).I believe it would be more efficient to add new filter presets to
ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/constants.jswhere we can distinguish betweenGroupandProjectlevel. However, since we're already implementing the Report Type filters in !181528 (merged), I suggest we include this change there to keep our changes focused.Another idea would be to add these extra filter presets once we are removing the ToolToken entirely.
I am curious to hear what you folks think would be the best and most efficient approach here, so feel free to share your thoughts on this!
😄