Improve the MR item details on the open MRs dropdown in Blob view
Context
Please see: #448868 (closed)
Design
| State | Screen |
|---|---|
| Default | |
| On hover of badge |
|
| On click of badge |
|
Additional notes
- Max height of the component is <TBD>. Overflow will scroll. This is a small edge case, as expected number of MRs per file is 1 - 2.
Implementation
Implementation breakdown
| Context | Deliverable |
|---|---|
|
By the end of Milestone 17.10 we will address (context):
|
|
|
#520125 (closed) (this) |
This issue covers:
|
Accessibility guidelines for implementation
From #520125 (comment 2421875700):
-
GlBadgewith tooltip:BTooltiphas a known issue, so the element with a tooltip needs both atitleand anaria-labelattributes -
GlDisclosurecomponent: use:toggle-text="__('A list of open merge requests')"(EDIT: I've changed that a bit becauseOpen merge requestsmight suggest opening a page with merge requests listing) andtext-sr-onlyprops on the dropdown to provide context for screen readers. We can omit the number of the MRs in the toggle text. When going through the disclosure, a screen reader will announce the total number in the disclosure group and then "1 out of 4", "2 out of 4" for each item in the disclosure -
GlDisclosureItemcomponent: we can omit an aria-label for the branch icon in each disclosure item, as it's only decorative.
Edited by Alyssa Trinh


