"GitLab for Jira Cloud" app OAuth broken if relative URL path coincides with a system executable

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

GitLab Self-Managed configured with a relative URL, where the path coincides with a system executable, like git, ps, or ls

Steps to reproduce

  • Install GitLab
  • Configure external_url with a relative path git (for example https://gitlab.example.com/git)
  • Configure "GitLab for Jira Cloud" integration (by installing via the Atlassian Marketplace)
  • Try authenticating with the app

What is the current bug behavior?

Clicking the blue Sign in button redirects to https://gitlab.example.com/git/git/oauth/authorize?client_id=xxxxx_uri=https%3A%2F%2Fgitlab.com%2F-%2Fjira_connect%2Foauth_callbacks(&response_type=code&scope=api(...) (duplicating the path for "GitLab for Jira Cloud" OAuth redirect i.e./git/git`)

What is the expected correct behavior?

It should not duplicate the /git path

Relevant logs and/or screenshots

image

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Workarounds

Edited by 🤖 GitLab Bot 🤖