MRs should only appear in one list

Proposal

MRs should appear in one list.

Remove the section list "Approved by others". This mapping shows how the action lists and badges related.

• Returned to you
• Review requested
• Assigned to you
• Waiting for assignee
• Waiting for approvals
• Approved by you
• Approved by others

Background

From [FEEDBACK] [INTERNAL] [v2] Action focused merge... (#512314 - closed)

I have duplicate MRs in Waiting for approvals and Approved by others. Maybe they could only appear in Waiting for approvals? 🤔

#512314 (comment 2294550495)

they also show up as dupes in both Approvals required and Approved by others.

#512314 (comment 2297567016)

From previous iterations

From #460910 (comment 2070978367)

I've got a few MRs which are appearing in two lists... on the one hand this sort of makes sense, because there are technically different states of the reviews... on the other hand it seems like maybe we should pick the most appropriate single list?

Scenario: where on the page would I expect the merge request to be?

I think the key is to ask "are the approval needs satisfied?" Could this MR merge right now, based on the current approvals? If the answer is "no" I think it still belongs in "Waiting for reviewers."

Here's an example. A merge request contains both docs changes AND a change that requires a database maintainer to review. Say that the PM and the technical writer have both approved, but the database maintainer hasn't yet. To me, that merge request should still be listed in "waiting for reviewers."