Convert the onboarding progress update to not raise on errors
Currently we call onboarding_progress.update! on updates to the onboarding progress that is then observed by Learn GitLab.
The !
has the side effect of raising an error. This is not ideal as the onboarding progress should be a 'best effort' operation that does not cause exceptions to be raised(opinion). The only time this should raise currently is likely with a systemic database or application issue, but the issue remains that ideally this is a best effort operation and therefore we should convert to remove the !
on update
.
We could instead log the exception, but I can't think of any other reason besides a systemic issue that would cause this to error out, so I wouldn't bother logging this for now if it fails.
original description
The following discussion from !149617 (merged) should be addressed:
-
@dstull started a discussion: thought (non-blocking):
I find it alarming here that we are calling
update!
. This will raise/halt execution if called in the foreground for something that is arguably a 'nice to have' and not critical to app operation.We should consider using
update
without the!
here... or at the least, make 2 methods ofregister!
for background processes andregister
for foreground processes.