MR approval notifications delayed until other rules are satisfied
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Repro steps:
- Configure a repo with multiple MR approval rules, e.g. both "A developer must approve" and "CI user must approve".
- Create an MR.
- Have a developer approve the MR.
- Have CI approve the MR.
- Have a second developer approve the MR.
Observed:
- Email notification of the first developer approval is NOT generated.
- Email notification of the CI approval IS generated.
- Email notification of the second developer approval IS generated.
It appears that notifications are not generated until/unless all approval rules are satisfied when the approval is granted. Earlier approval events are "ignored" w.r.t. notifications.
Desired:
- Email notification of should be generated for every event.
This is important because I want to see everything that's happening on my MR. For example, I (or my manager) might stop nagging a colleague to review an MR as soon as they review/approve it. But I don't know that's happened if I don't get the email notification, unless I go and refresh each MR's web page to check over and over. The entire point of email notifications is to pro-actively notify the user of status changes so they don't have to "poll" the MR page manually.
(This bug applies to on-premises GitLab Enterprise Edition v16.9.4-ee)