Follow-up from "Add utils and constants for the AI impact dashboard"
The following discussions from !148717 (merged) should be addressed:
-
@rcrespo3 started a discussion: suggestion (non-blocking): WDYT about creating a new namespace for AI Impact:
'AiImpactAnalytics|Monthly user engagement with AI Code Suggestions. Percentage ratio calculated as monthly unique Code Suggestions users / total monthly unique contributors.',
-
@rcrespo3 started a discussion: (+1 comment) question (non-blocking): Why are we not accessing these elements from
timePeriods
directly? Are thetimePeriods
not guaranteed to be in order? It'd make things a bit more performant since we wouldn't have to traverse the array to find them.const firstMonth = timePeriods.at(-1); const lastMonth = timePeriods[0];
-
@rcrespo3 started a discussion: suggestion (non-blocking): Let's add the new namespace for this as well:
label: s__('AiImpactAnalytics|Code Suggestions usage'),
-
@ekigbo started a discussion: nitpick: this can probably just be moved directly to
~/lib/utils/datetime_utility
-
@ekigbo started a discussion: nitpick: instead of aliasing, WDYT about directly exporting this as
AI_IMPACT_TABLE_METRICS
. I like the clarity of the different constants since each table supports a different set of metrics. -
@ekigbo started a discussion: nitpick:
label: __('Change (%)'),