Reinstate "Make multi-version upgrades DB migration job required to pass" after it's been reverted
This issue is to reinstate !147579 (merged) after it's been reverted by !148218 (merged) due to gitlab-org/quality/engineering-productivity/master-broken-incidents#5679 (closed).
The following discussion from !147579 (merged) should be addressed:
-
@rymai started a discussion: (+1 comment) observation: I think this will always evaluate to
true
since the variable is set in the job itself. This is probably the cause of the brokenmaster
since the failure happened for a doc-only commit: 6f3c865f
We should make it reverse, i.e.:
- if: '$ENABLE_DB_MULTI_VERSION_UPGRADE != /true|yes|1/i'
when: never
and we should define ENABLE_DB_MULTI_VERSION_UPGRADE
directly in .gitlab-ci.yml
.
Alternatively, we could enable the job by default, and allow to disable it:
- if: '$DISABLE_DB_MULTI_VERSION_UPGRADE'
when: never
Edited by Nailia Iskhakova